 Miikka Väisälä
|
ad53a0b5f0
|
sink_particle.md edited online with Bitbucket
Comments on JP's accretion suggestions.
|
2019-08-05 05:24:59 +00:00 |
|
|
jpekkila
|
6dfd03664d
|
Still does not work. I'm starting to think that instead of this one huge revision, we should modify the existing interface step-by-step.
|
2019-08-02 15:31:24 +03:00 |
|
|
jpekkila
|
5f2378e91b
|
Now compiles (does not work though)
|
2019-08-02 15:15:18 +03:00 |
|
|
jpekkila
|
567ad61465
|
Multinode MPI implementation should be done later in its own branch. The focus of this branch is to revise the node and device layers. Commented out references to the Grid layer.
|
2019-08-02 13:54:54 +03:00 |
|
|
JackHsu
|
239e8b4d3e
|
Can set the density for intitial condition from astaroth.conf.
|
2019-08-02 17:31:49 +08:00 |
|
|
Miikka Vaisala
|
3c87fe0b48
|
Added unit_mass
|
2019-08-02 13:48:09 +08:00 |
|
|
jpekkila
|
2b6bf10ae6
|
Dummy implementation of the Grid interface
|
2019-08-01 18:37:36 +03:00 |
|
|
jpekkila
|
328b809efe
|
Added the revised node interface
|
2019-08-01 14:04:11 +03:00 |
|
|
Miikka Vaisala
|
99d80f7175
|
Renaming for bug correction. Use now AC_M_sink_Msun in astaroth.conf instead of AC_M_sink!
|
2019-08-01 18:06:57 +08:00 |
|
|
Miikka Vaisala
|
6927ddff5a
|
Correct an obscure bug.
|
2019-08-01 17:57:21 +08:00 |
|
|
Miikka Vaisala
|
e1b34480fc
|
Default sink position at [pi, pi, pi] for clarity.
|
2019-08-01 17:25:14 +08:00 |
|
|
JackHsu
|
29d6a9b00a
|
Fixed scaling for sink particle, and added softening factor.
|
2019-08-01 16:33:58 +08:00 |
|
|
Miikka Vaisala
|
718a275bcf
|
Proiper softening factor
|
2019-08-01 14:12:21 +08:00 |
|
|
JackHsu
|
d5a3d896aa
|
Fixed astaroth.conf.
|
2019-08-01 13:36:05 +08:00 |
|
|
jpekkila
|
4594d73022
|
Merge branch 'cmakelist_rewrite_and_C_API_conformity_07-26' into node_device_interface_revision_07-23
|
2019-07-31 20:13:19 +03:00 |
|
|
jpekkila
|
92376588ba
|
Merge branch 'master' into cmakelist_rewrite_and_C_API_conformity_07-26
|
2019-07-31 20:12:22 +03:00 |
|
|
jpekkila
|
fb0610c1ba
|
Intermediate changes to the revised node interface
|
2019-07-31 20:04:39 +03:00 |
|
|
jpekkila
|
0a5d025172
|
Formatting
|
2019-07-31 19:08:16 +03:00 |
|
|
jpekkila
|
9b7f4277fc
|
Fixed errors in device.cu
|
2019-07-31 19:07:26 +03:00 |
|
|
jpekkila
|
49026bd26b
|
Revised device interface done
|
2019-07-31 18:46:41 +03:00 |
|
|
jpekkila
|
5be775dbff
|
Various intermediate changes
|
2019-07-31 17:48:48 +03:00 |
|
|
JackHsu
|
499dcabe0a
|
Merge branch 'master' into sink_20190723
|
2019-07-31 17:12:45 +08:00 |
|
|
JackHsu
|
24a56044f0
|
Fixed gravitating particle.
|
2019-07-31 17:07:05 +08:00 |
|
|
JackHsu
|
5361ee5706
|
Fixed gravitational force inputs.
|
2019-07-31 17:07:04 +08:00 |
|
|
jpekkila
|
15ad7182db
|
Added sum reduction. NOTE: Scalar sum does not pass the automated test but vector sum does. I couldn't see anything wrong with the code itself and I strongly suspect that the failures are caused by loss of precision due to summing a huge amount of numbers of different magnitudes. However I'm not yet completely sure. Something like the Kahan summation algorithm might be useful if the errors are really caused by fp arithmetic.
|
2019-07-31 17:07:03 +08:00 |
|
|
jpekkila
|
f7bd84af46
|
Added macros for getting int3 and AcReal3 device constants from within kernels (and DSL).
|
2019-07-31 17:07:02 +08:00 |
|
|
jpekkila
|
4e44f3a872
|
The previous commit to ac_mkbuilddir.sh was not enough. Added a line that makes the script to stop if any of the commands fail to avoid cluttering the base astaroth directory. In my case the issue was permission denied when trying to create a project directory in /MYSCRATCH (system root directory) instead of MYSCRATCH (astaroth/MYSCRATCH)
|
2019-07-31 17:07:01 +08:00 |
|
|
jpekkila
|
5390d68d7c
|
ac_mkbuilddir.sh did not stop if the directory specified by the user did not exist. This lead to messing up the base astaroth directory with temporary cmake files. Added -p flag to mkdir to create parent directories if necessary to avoid this
|
2019-07-31 17:07:00 +08:00 |
|
|
Miikka Vaisala
|
a410143c10
|
Wrote down JPs suggestion for later use.
|
2019-07-31 10:11:57 +08:00 |
|
|
jpekkila
|
6b55fce54a
|
Merge branch 'c_standalone_compilation_test_07-23' into node_device_interface_revision_07-23
|
2019-07-30 14:36:17 +03:00 |
|
|
jpekkila
|
b7c5274f45
|
Merge branch 'master' into c_standalone_compilation_test_07-23
|
2019-07-30 14:35:46 +03:00 |
|
|
jpekkila
|
efd9d54fef
|
Stashing WIP changes (interface revision) s.t. I can continue work on a different machine
|
2019-07-30 14:34:44 +03:00 |
|
|
jpekkila
|
1ceb6739ae
|
Merge branch 'master' into node_device_interface_revision_07-23
|
2019-07-30 14:31:33 +03:00 |
|
|
jpekkila
|
62100b1140
|
Merge branch 'master' of https://bitbucket.org/jpekkila/astaroth
|
2019-07-30 14:28:25 +03:00 |
|
|
jpekkila
|
69deef66fe
|
Added sum reduction. NOTE: Scalar sum does not pass the automated test but vector sum does. I couldn't see anything wrong with the code itself and I strongly suspect that the failures are caused by loss of precision due to summing a huge amount of numbers of different magnitudes. However I'm not yet completely sure. Something like the Kahan summation algorithm might be useful if the errors are really caused by fp arithmetic.
|
2019-07-30 14:28:18 +03:00 |
|
|
jpekkila
|
fdc1e7333c
|
Added macros for getting int3 and AcReal3 device constants from within kernels (and DSL).
|
2019-07-30 09:10:06 +00:00 |
|
|
JackHsu
|
34573d7d63
|
Corrected acciden removal.
|
2019-07-30 13:32:44 +08:00 |
|
|
JackHsu
|
a6dcee2381
|
Forgot to use lengh() instead of dlength_vec().
|
2019-07-30 11:50:20 +08:00 |
|
|
JackHsu
|
0acf52d1b4
|
Fixed some syntax errors and changed LGRAVITY to LSINK. Will test if this works later.
|
2019-07-30 11:47:18 +08:00 |
|
|
jpekkila
|
d614a03653
|
Made CMake to use the default compiler on system PATH. If the generic compiler names (cc, c++) point to some old version, then cmake would otherwise use those instead of the latest available compiler.
|
2019-07-29 16:07:31 +03:00 |
|
|
jpekkila
|
a3359b0d04
|
CONFIG_PATH is now supplied by ac_mkbuilddir. While using would be a bit more idiomatic, ASTAROTH_CONF_PATH is probably safer since ac_mkbuilddir.sh does the copying and knows for sure what the correct path is.
|
2019-07-29 15:55:27 +03:00 |
|
|
jpekkila
|
9796d5e981
|
The previous commit to ac_mkbuilddir.sh was not enough. Added a line that makes the script to stop if any of the commands fail to avoid cluttering the base astaroth directory. In my case the issue was permission denied when trying to create a project directory in /MYSCRATCH (system root directory) instead of MYSCRATCH (astaroth/MYSCRATCH)
|
2019-07-29 15:35:51 +03:00 |
|
|
jpekkila
|
7b5a02bf0f
|
The previous commit to ac_mkbuilddir.sh was not enough. Added a line that makes the script to stop if any of the commands fail to avoid cluttering the base astaroth directory. In my case the issue was permission denied when trying to create a project directory in /MYSCRATCH (system root directory) instead of MYSCRATCH (astaroth/MYSCRATCH)
|
2019-07-29 15:35:17 +03:00 |
|
|
jpekkila
|
abe4dfb4fe
|
ac_mkbuilddir.sh did not stop if the directory specified by the user did not exist. This lead to messing up the base astaroth directory with temporary cmake files. Added -p flag to mkdir to create parent directories if necessary to avoid this
|
2019-07-29 15:22:44 +03:00 |
|
|
jpekkila
|
5801144336
|
ac_mkbuilddir.sh did not stop if the directory specified by the user did not exist. This lead to messing up the base astaroth directory with temporary cmake files. Added -p flag to mkdir to create parent directories if necessary to avoid this
|
2019-07-29 15:21:15 +03:00 |
|
|
JackHsu
|
e7a2734ab6
|
reparied a delection I did by mistake.
|
2019-07-29 18:06:57 +08:00 |
|
|
JackHsu
|
820132cfe9
|
I attemped to write a complete LSINK module. Haven't tested how it works but just serve as a save point.
|
2019-07-29 17:53:04 +08:00 |
|
|
JackHsu
|
d1ca196ccd
|
Added declaration of constants for sink particle. Still in the process of understanding how values are passed, but I've realized how physical equations are defined in stencil_process.sps and in principle I can replicate that for sink particle(which will mostly be gravity).
|
2019-07-29 13:18:24 +08:00 |
|
|
jpekkila
|
7c256d3bb3
|
Added a comment about a redundant variable
|
2019-07-26 15:13:19 +03:00 |
|
|
jpekkila
|
c9fafe41e5
|
Tidied the CMakeLists, moved stuff to more logical places and added comments. Also tested that ALTER_CONF=ON still works
|
2019-07-26 15:12:55 +03:00 |
|